-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: fix regression test, add a new CI workflow #3456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2/master
Are you sure you want to change the base?
Conversation
|
I looked at |
|
I tried to review the script again, and fixed two small things in bbe5239:
Also I removed the test Until I write this comment, the tests has started, but it seems that no performance improvement. (And beside of that there are two failed tests...) |
|
If I remember correctly, Apache waits for connections to be closed or whatever. I do not think it sends a RST or something, but it really waits. So if it's slow to stop, I would look at the connection table during the stopping. Stopping Apache in production is always slow. In a test situation that's not ideal. Maybe you want to kill it instead. Take a look at my script https://www.netnea.com/files/apachex that I use for control of Apache in my lab. It's a very rough tool, more a mallet than a screwdriver, but it never fails me to kill and restore apache instantly. Not sure this is the right path, but that's what I have in mind. |
|
There are probably two things you can do:
The first is just a nice-to-have of course. I'd absolutely simply kill httpd. There's no reason for handling open connections gracefully in this scenario. |
|
Thanks for ideas,
All requests send
I tried, but then many other weird issues came out. Eg. when
I'm afraid I have to reorganize the complete start/stop mechanism. |
|



what
This PR fixes the last broken regression test and adds the whole regression test workflow to GH CI.
why
The regression tests were almost finished, now I found another broken test. After fixed that I prepared a new workflow for GH CI, where we run these regression tests.
I switched the operation system to Ubuntu 24.04 (from 22.04). In Ubuntu 24.04 the old PCRE (libpcre3) is not installed by default, I had to add it explicitly.
I tried to follow the build matrix as it's in other workflows, but a complete regression test takes about 29 minutes - I think that's very slow. On my build machine (which is not a strong one) it takes about 6-7 minutes.
Unfortunately we can't fix this, the reason is that the operation of a test: each tests creates a config, start an Apache server with that config, send a request and check the output (files, response, etc).
I don't know if it's worth it.
references
#3425