-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
BUG: to_numeric fails to convert a Pyarrow Decimal series containing NA values #62975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wisznie
wants to merge
5
commits into
pandas-dev:main
Choose a base branch
from
wisznie:bugfix-to-numeric-when-pyarrow-with-na-continuation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fb54089
BUG: to_numeric raise ValueError when the arrow array contains NA
chilin0525 7c2a65e
TST: to_numeric raise ValueError when the arrow array contains NA
chilin0525 5ac82aa
add changelog entry
chilin0525 a5e5065
Address some PR feedback
wisznie 3e9895d
Merge branch 'main' into bugfix-to-numeric-when-pyarrow-with-na-conti…
wisznie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -902,3 +902,20 @@ def test_coerce_pyarrow_backend(): | |
| result = to_numeric(ser, errors="coerce", dtype_backend="pyarrow") | ||
| expected = Series([1, 2, None], dtype=ArrowDtype(pa.int64())) | ||
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "dtype", | ||
| [ | ||
| "ArrowDtype", | ||
| ], | ||
| ) | ||
| def test_to_numeric_arrow_decimal_with_na(dtype): | ||
| # GH 61641 | ||
| pa = pytest.importorskip("pyarrow") | ||
| target_class = globals()[dtype] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is very confusing. Can you parametrize with the class directly? |
||
| decimal_type = target_class(pa.decimal128(3, scale=2)) | ||
| series = Series([1, None], dtype=decimal_type) | ||
| result = to_numeric(series, errors="coerce") | ||
|
|
||
| tm.assert_series_equal(result, series) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a comment in the original PR, there was a request to parametrize different dtypes that should be a no-op.
On the top of my head, I think it's possible to test
Int64DtypeandFloat64Dtype, although, I think it will require to create another test for non-pyarrow.