Use TypeSystem in AssertSameBooleanExpectedRule

[staabm]

I think it makes sense that we get the same error when working with constants and known value.

phpstan-phpunit/tests/Rules/PHPUnit/data/assert-same-boolean-expected.php

Lines 29 to 33 in 450bfc0

	public function testConstants(): void
	{
	\PHPUnit\Framework\Assert::assertSame(PHPSTAN_PHPUNIT_TRUE, 'foo');
	\PHPUnit\Framework\Assert::assertSame(PHPSTAN_PHPUNIT_FALSE, 'foo');
	}

[staabm]

another case in which infection made me add new tests:

[ondrejmirtes]

I disagree with this. I feel like that when someones does:

$this->assertSame(Foo::BAR, $expected);

It's there on purpose and it means "expected should be the same as Foo::BAR". The value of Foo::BAR might be true right now but it's there so that the value can change.

Changing the code to:

$this->assertTrue($expected);

would lose information.

[staabm]

ok. reduced it to the new tests

[staabm]

remaining tests are here to kill mutants

[ondrejmirtes]

Thank you!