Fix get_class return type
#4456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Oct 19, 2025
| } elseif ($objectClassNames !== []) { | ||
| return new GenericClassStringType($type); | ||
| } elseif ($type instanceof ObjectWithoutClassType) { | ||
| if ($type instanceof ObjectShapeType) { |
There was a problem hiding this comment.
The logic
if (!$objectType instanceof TemplateType && $objectType instanceof ObjectWithoutClassType) {
$classStringType = new ClassStringType();
} else {
$classStringType = new GenericClassStringType($objectType);
}
Doesn't work for ObjectShapeType and gaves
class-string<object{foo: bar}>
which is weird.
|
|
||
| return new ConstantBooleanType(false); | ||
| $isObject = $type->isObject(); | ||
| if ($isObject->no()) { |
There was a problem hiding this comment.
Answering #2350 (comment)
It can be maybe for at least template type or mixed type
| return new ConstantBooleanType(false); | ||
| } | ||
|
|
||
| if ($type instanceof StaticType) { |
There was a problem hiding this comment.
I use a if/else as suggested (I think) in #2350 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2350
Closes phpstan/phpstan#4890