Improve inference on FuncCall === FuncCall #4513
Open
+98
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Nov 2, 2025
Comment on lines
+2248
to
+2259
| // Normalize to: fn() === expr | ||
| if ($rightExpr instanceof FuncCall && !$leftExpr instanceof FuncCall) { | ||
| [$leftExpr, $rightExpr] = [$rightExpr, $leftExpr]; | ||
| $specifiedTypes = $this->resolveNormalizedIdentical(new Expr\BinaryOp\Identical( | ||
| $rightExpr, | ||
| $leftExpr, | ||
| ), $scope, $context); | ||
| } else { | ||
| $specifiedTypes = $this->resolveNormalizedIdentical(new Expr\BinaryOp\Identical( | ||
| $leftExpr, | ||
| $rightExpr, | ||
| ), $scope, $context); | ||
| } |
There was a problem hiding this comment.
moved already existing normalization logic here
staabm
commented
Nov 2, 2025
| } | ||
|
|
||
| // merge result of fn1() === fn2() and fn2() === fn1() | ||
| if ($rightExpr instanceof FuncCall && $leftExpr instanceof FuncCall) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13749
if one of the involved function calls got already narrowed, switching the operands can lead to more precise types.