Skip to content

count(non-empty-array, COUNT_RECURSIVE) is int<1, max> #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.1.x
Choose a base branch
from
+102 −8
Open

count(non-empty-array, COUNT_RECURSIVE) is int<1, max> #4515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c92f528
`count(non-empty-array, COUNT_RECURSIVE)` is `int<1, max>`
staabm Nov 2, 2025
de9d8f9
Update count-recursive.php
staabm Nov 2, 2025
83091c0
cs
staabm Nov 2, 2025
aba344e
test union
staabm Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions src/Type/Php/CountFunctionReturnTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
use PHPStan\Analyser\Scope;
use PHPStan\DependencyInjection\AutowiredService;
use PHPStan\Reflection\FunctionReflection;
use PHPStan\TrinaryLogic;
use PHPStan\Type\Constant\ConstantIntegerType;
use PHPStan\Type\DynamicFunctionReturnTypeExtension;
use PHPStan\Type\IntegerRangeType;
use PHPStan\Type\Type;
use function count;
use function in_array;
use const COUNT_RECURSIVE;
use const COUNT_NORMAL;

#[AutowiredService]
final class CountFunctionReturnTypeExtension implements DynamicFunctionReturnTypeExtension
Expand All @@ -28,18 +30,31 @@ public function getTypeFromFunctionCall(
Scope $scope,
): ?Type
{
if (count($functionCall->getArgs()) < 1) {
$args = $functionCall->getArgs();
if (count($args) < 1) {
return null;
}

if (count($functionCall->getArgs()) > 1) {
$mode = $scope->getType($functionCall->getArgs()[1]->value);
if ($mode->isSuperTypeOf(new ConstantIntegerType(COUNT_RECURSIVE))->yes()) {
return null;
$arrayType = $scope->getType($args[0]->value);
if (!$this->isNormalCount($functionCall, $arrayType, $scope)->yes()) {
if ($arrayType->isIterableAtLeastOnce()->yes()) {
return IntegerRangeType::fromInterval(1, null);
}
return null;
}

return $scope->getType($functionCall->getArgs()[0]->value)->getArraySize();
return $scope->getType($args[0]->value)->getArraySize();
}

private function isNormalCount(FuncCall $countFuncCall, Type $countedType, Scope $scope): TrinaryLogic
{
if (count($countFuncCall->getArgs()) === 1) {
$isNormalCount = TrinaryLogic::createYes();
} else {
$mode = $scope->getType($countFuncCall->getArgs()[1]->value);
$isNormalCount = (new ConstantIntegerType(COUNT_NORMAL))->isSuperTypeOf($mode)->result->or($countedType->getIterableValueType()->isArray()->negate());
}
return $isNormalCount;
}

}
2 changes: 1 addition & 1 deletion tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2464,7 +2464,7 @@ public static function dataBinaryOperations(): array
'count($arrayOfIntegers)',
],
[
'int<0, max>',
'3',
'count($arrayOfIntegers, \COUNT_RECURSIVE)',
],
[
Expand Down
79 changes: 79 additions & 0 deletions tests/PHPStan/Analyser/nsrt/count-recursive.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<?php

namespace CountRecursive;

use function PHPStan\Testing\assertType;

class HelloWorld
{
public function countArray(array $arr): void
{
if (count($arr) > 2) {
assertType('non-empty-array', $arr);
assertType('int<3, max>', count($arr));
assertType('int<1, max>', count($arr, COUNT_NORMAL)); // could be int<3, max>
assertType('int<1, max>', count($arr, COUNT_RECURSIVE));
}
}

public function countArrayNormal(array $arr): void
{
if (count($arr, COUNT_NORMAL) > 2) {
assertType('non-empty-array', $arr);
assertType('int<1, max>', count($arr)); // could be int<3, max>
assertType('int<3, max>', count($arr, COUNT_NORMAL));
assertType('int<1, max>', count($arr, COUNT_RECURSIVE));
}
}

public function countArrayRecursive(array $arr): void
{
if (count($arr, COUNT_RECURSIVE) > 2) {
assertType('non-empty-array', $arr);
assertType('int<1, max>', count($arr));
assertType('int<1, max>', count($arr, COUNT_NORMAL));
assertType('int<3, max>', count($arr, COUNT_RECURSIVE));
}
}

public function countArrayUnionMode(array $arr): void
{
$mode = rand(0,1) ? COUNT_NORMAL : COUNT_RECURSIVE;
if (count($arr, $mode) > 2) {
assertType('non-empty-array', $arr);
assertType('int<3, max>', count($arr, $mode));
assertType('int<1, max>', count($arr, COUNT_NORMAL));
assertType('int<1, max>', count($arr, COUNT_RECURSIVE));
}
}

/** @param list<int> $list */
public function countList($list): void
{
if (count($list) > 2) {
assertType('int<3, max>', count($list));
assertType('int<1, max>', count($list, COUNT_NORMAL));
assertType('int<1, max>', count($list, COUNT_RECURSIVE));
}
}

/** @param list<int> $list */
public function countListNormal($list): void
{
if (count($list, COUNT_NORMAL) > 2) {
assertType('int<1, max>', count($list));
assertType('int<3, max>', count($list, COUNT_NORMAL));
assertType('int<1, max>', count($list, COUNT_RECURSIVE));
}
}

/** @param list<int> $list */
public function countListRecursive($list): void
{
if (count($list, COUNT_RECURSIVE) > 2) {
assertType('int<1, max>', count($list));
assertType('int<1, max>', count($list, COUNT_NORMAL));
assertType('int<3, max>', count($list, COUNT_RECURSIVE));
}
}
}
Loading