-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update plotly.js to v3.2.0 and associated files #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a58a365
Update plotly.js to v3.2.0 and associated files
camdecoster 46ee9b2
Update Jupyter support files
camdecoster 5586cf9
Use labextension files from CI because they are different
camdecoster 056b497
Remove old build file
camdecoster 89a1f1b
Revert indentation changes
camdecoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,35 @@ | ||
| { | ||
| "name": "jupyterlab-plotly", | ||
| "main": "lib/mimeExtension.js", | ||
| "version": "6.0.1", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/plotly/plotly.py" | ||
| }, | ||
| "description": "The plotly Jupyter extension", | ||
| "author": "The plotly.py team", | ||
| "license": "MIT", | ||
| "scripts": { | ||
| "build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts", | ||
| "build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts", | ||
| "build:labextension": "jupyter labextension build .", | ||
| "build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension", | ||
| "watch": "npm run build -- --watch --sourcemap=inline", | ||
| "typecheck": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "lodash-es": "^4.17.21", | ||
| "plotly.js": "3.1.1", | ||
| "@lumino/widgets": "~2.4.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@jupyterlab/builder": "^4.3.6 || ^3.6.8", | ||
| "@types/plotly.js": "^2.33.4", | ||
| "esbuild": "^0.23.1", | ||
| "typescript": "^5.6.2" | ||
| }, | ||
| "jupyterlab": { | ||
| "mimeExtension": true, | ||
| "outputDir": "../plotly/labextension" | ||
| } | ||
| "name": "jupyterlab-plotly", | ||
| "main": "lib/mimeExtension.js", | ||
| "version": "6.0.1", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/plotly/plotly.py" | ||
| }, | ||
| "description": "The plotly Jupyter extension", | ||
| "author": "The plotly.py team", | ||
| "license": "MIT", | ||
| "scripts": { | ||
| "build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts", | ||
| "build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts", | ||
| "build:labextension": "jupyter labextension build .", | ||
| "build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension", | ||
| "watch": "npm run build -- --watch --sourcemap=inline", | ||
| "typecheck": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "lodash-es": "^4.17.21", | ||
| "plotly.js": "3.2.0", | ||
| "@lumino/widgets": "~2.4.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@jupyterlab/builder": "^4.3.6 || ^3.6.8", | ||
| "@types/plotly.js": "^2.33.4", | ||
| "esbuild": "^0.23.1", | ||
| "typescript": "^5.6.2" | ||
| }, | ||
| "jupyterlab": { | ||
| "mimeExtension": true, | ||
| "outputDir": "../plotly/labextension" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camdecoster can we keep the previous indentation here? Doesn't matter THAT much but it's like 60% of the diff for this PR and has a good chance of getting reverted the next time we bump the Plotly.js version.
(I guess I spoke too soon in saying we don't need a JSON/JS formatter for Plotly.py...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. ESLint took over with a default of 2 spaces per level since no formatter is set for this repo.