Interfaces for managing Continuous Recording #12
Conversation
| @@ -0,0 +1,9 @@ | |||
| ## Request | |||
There was a problem hiding this comment.
Given how generic this .srv is, why not just make it something like BasicRequest.srv?
There was a problem hiding this comment.
Yeah we can make a basic trigger request, since even StopBagRecording.srv is the same
| # Start time for retention | ||
| polymath_msgs/DateTime start_time | ||
|
|
||
| # End time for retention | ||
| polymath_msgs/DateTime end_time |
There was a problem hiding this comment.
why define a new datetime? Why not rostime? Let other tools define the human readable interface
There was a problem hiding this comment.
Since all bags are stored with UTC timestamp, I assume it'll be more intuitive for someone to provide that when requesting to retain bags instead of builtin_interfaces/Time (sec + nanosec). Would be intuitive to use from raw service panels and cli as well if required
There was a problem hiding this comment.
We will be writing tooling in Foxglove/Polyglot to set retentions right? They can manage the human readable datetime -> ros time conversion.
No description provided.