Skip to content

Conversation

@100xmanas
Copy link

Fixes #3684

Description:
This PR improves the styling of the banner message when users switch languages.

before

500286459-e943c814-e7e3-40fd-82b0-7bf538e3475c.mov

After

1018.mp4

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @100xmanas thank you for the changes but web editor uses consistent styling and colors for all the components so fixed color are not suitable.

@100xmanas
Copy link
Author

@yugalkaushik

fixed!

Apply consistent styling and colors to the banner


If there's anything else, please let me know -- I'm happy to improve it further! 😊

Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@100xmanas
Copy link
Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improving styling of banner message when u switch languages

2 participants