-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add guidance about temperature modeling to User Guide #2591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| +-------------------------------------------+--------+------------+--------------------------------------------------------------------+ | ||
| | Model | Type | Transient? | Inputs | | ||
| | | | +----------------+---------------------+------------+----------------+ | ||
| | | | | POA irradiance | Ambient temperature | Wind speed | Downwelling IR | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think "IR" is obvious or should we include a note defining the acronym?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a note IMO
| Currently, pvlib provides no functionality for fitting parameter values | ||
| using measured temperature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should at least mention the conversion capabilities in GeneralLinearModel
|
One thing that could be added is the parameter conversion from one model to another. Please leave this open for a few weeks as I'd like to comment more. |
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
| Temperature models predict one of two quantities: | ||
|
|
||
| - *module temperature*: the temperature as measured at the back surface | ||
| of a PV module. Easy to measure, but usually a few degrees less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| of a PV module. Easy to measure, but usually a few degrees less | |
| of a PV module. Easy to measure, but usually less |
I prefer not to add this pseudo–/semi-quantification, in case anyone misunderstands and really extracts a quantitative difference here that they then overgeneralize. If it's less we can just say less, and if we want to explain a relation we can do that.
| Cell temperature is typically thought to be slightly higher than module | ||
| temperature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Cell temperature is typically thought to be slightly higher than module | |
| temperature. |
Shall we delete this? It seems to be covered in the point above that I commented on separately. It also reads a bit disjointed to me
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Continuing in a broader thrust of developing our user guide section. Previously: