Skip to content

Bugfix/atmos refract typo #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+5 −2
Open

Bugfix/atmos refract typo #2592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
216db9e
Prevent atmos_refract docstring typo regression
josephradford Nov 5, 2025
f427491
Fix atmos_refract parameter name typo in docstrings
josephradford Nov 5, 2025
452876d
Break long lines up in test files
josephradford Nov 5, 2025
62a5ce0
Revert "Break long lines up in test files"
josephradford Nov 5, 2025
6c82ccb
Revert "Prevent atmos_refract docstring typo regression"
josephradford Nov 5, 2025
eaa6264
Add PR number and contributer name to whatsnew
josephradford Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.13.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ Enhancements
Documentation
~~~~~~~~~~~~~
* Provide an overview of single-diode modeling functionality in :ref:`singlediode`. (:pull:`2565`)
* Fix typo in parameter name ``atmos_refract`` in :py:func:`pvlib.solarposition.spa_python`
and :py:func:`pvlib.spa.solar_position`. (:issue:`2532`, :pull:`2592`)


Testing
Expand All @@ -67,3 +69,4 @@ Maintenance
Contributors
~~~~~~~~~~~~
* Cliff Hansen (:ghuser:`cwhanse`)
* Joseph Radford (:ghuser:`josephradford`)
2 changes: 1 addition & 1 deletion pvlib/solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def spa_python(time, latitude, longitude,
using time.year and time.month from pandas.DatetimeIndex.
For most simulations the default delta_t is sufficient.
The USNO has historical and forecasted delta_t [3]_.
atmos_refrac : float, optional
atmos_refract : float, optional
The approximate atmospheric refraction (in degrees)
at sunrise and sunset.
how : str, optional, default 'numpy'
Expand Down
2 changes: 1 addition & 1 deletion pvlib/spa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ def solar_position(unixtime, lat, lon, elev, pressure, temp, delta_t,
degrees C; used for atmospheric correction
delta_t : float or array
Difference between terrestrial time and UT1.
atmos_refrac : float
atmos_refract : float
The approximate atmospheric refraction (in degrees)
at sunrise and sunset.
numthreads: int, optional, default 8
Expand Down