warn instead of error for pinned versions #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this MR is to fix #161 however I think it's optimistic to believe Pyodide and its micropip related to that pyodide could do anything about packages not compatible/available for a specific Pyodide version.
The thing is, if I force version
0.28.0which is not compatible with pygame-ce there's apparently no way to force loading a previous version of pygame-ce even if it used to be compatible.This makes our discussion around pinned versions mostly irrelevant, although the logic to warn instead of always throwing is in place, I really would like to have a concrete example of when that warning should be read but the older package should still work (this is in particular for @mchilvers and @fpliger)
/cc @ntoll as it looks that we cannot control much of this dance, I might ping Hood around this topic too (he is not watching this space, it'll happen on discord).
Current State