Do not treat annotated self-assign as special #20148
Open
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20144.
Historically we have special treatment for
X = X"redefinitions" in global scope. This special case was introduced in #7144, and all test cases there are unannotated.I suspect that it was not supposed to include annotated cases at all (cc @JukkaL as the PR author - is my understanding correct?), because it skips a whole bunch of annotation checks - final, classvar, annotation sanity, plugins, etc.:
mypy/mypy/semanal.py
Lines 3269 to 3280 in 12d5da4