Add PluginFlags for customizing behaviour of plugin-generated nodes #20182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20008.
Following the discussion in #20008, this PR explores a "flag container" approach to customizing checks for plugin-generated nodes.
As a real-world example, I patched
pydanticmypy plugin (branch here) to address #19898. Using the flag container allowed me to remove theclassmethoddecorator application there which was just a wrong thing to do, probably misguided by the[override]error message for classmethods.This looks easier than exposing the whole LSP checks infrastructure as public API.
If I understand correctly, this is fully backwards-compatible. Still should be mentioned in the plugin changes issue, though.