Skip to content

Check slice scatter args for each dim #15628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check slice scatter args for each dim #15628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kernels/portable/cpu/util/slice_util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ bool check_slice_scatter_args(
Tensor output) {
ET_LOG_AND_RETURN_IF_FALSE(input.dim() > 0);

// Check dim. The dim planed to be selected on shall exist in input
// Check dim. The dim planned to be selected on shall exist in input
ET_LOG_AND_RETURN_IF_FALSE(dim_is_valid(dim, input.dim()));

// Input and output tensors should be the same shape and dtype
Expand All @@ -97,7 +97,7 @@ bool check_slice_scatter_args(
// The size of src tensor should follow these rules:
// - src.size(i) shall equal to input.size(i) if i != dim,
// - src.size(dim) shall equal to num_values
for (const auto d : c10::irange(input.dim() - 1)) {
for (const auto d : c10::irange(input.dim())) {
if (d != dim) {
ET_LOG_AND_RETURN_IF_FALSE(
tensors_have_same_size_at_dims(input, d, src, d));
Expand Down
Loading