Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Nov 6, 2025

Summary

Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests.

Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts.

Test plan

This is tested by the Backend test flow

cc @freddan80 @per @oscarandersson8218 @digantdesai

Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests.

Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts.


Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I3a45ade598924751fa1b3fd73631732788350345
@zingo zingo requested a review from cccclai as a code owner November 6, 2025 10:49
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Nov 6, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15632

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 4da688a with merge base d07a49a (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@zingo
Copy link
Collaborator Author

zingo commented Nov 6, 2025

Test fails unrelated

@zingo
Copy link
Collaborator Author

zingo commented Nov 6, 2025

Fails unrelated, no buck2 changes should be needed for this.

@Sebastian-Larsson Sebastian-Larsson merged commit acf5b4b into pytorch:main Nov 6, 2025
155 of 162 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
…ch#15632)

### Summary
Delay compile-spec creation in the backend test flow to prevent sharing
the temp directory between tests.

Previously, using a shared compile spec implied a shared temp directory.
After we began cleaning the temp directory after each test, this sharing
caused conflicts.

### Test plan
This is tested by the Backend test flow

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants