Skip to content

Use import type instead of import #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Use import type instead of import #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4298f
0.0.7
arnested Oct 17, 2025
0b212d1
Use `import type` instead of `import`
arnested Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/bun-mysql2/src/db/query_sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code generated by sqlc. DO NOT EDIT.

import mysql, { RowDataPacket, ResultSetHeader } from "mysql2/promise";
import mysql, { type RowDataPacket, type ResultSetHeader } from "mysql2/promise";

type Client = mysql.Connection | mysql.Pool;

Expand Down
2 changes: 1 addition & 1 deletion examples/bun-pg/src/db/query_sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code generated by sqlc. DO NOT EDIT.

import { QueryArrayConfig, QueryArrayResult } from "pg";
import type { QueryArrayConfig, QueryArrayResult } from "pg";

interface Client {
query: (config: QueryArrayConfig) => Promise<QueryArrayResult>;
Expand Down
2 changes: 1 addition & 1 deletion examples/node-mysql2/src/db/query_sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code generated by sqlc. DO NOT EDIT.

import mysql, { RowDataPacket, ResultSetHeader } from "mysql2/promise";
import mysql, { type RowDataPacket, type ResultSetHeader } from "mysql2/promise";

type Client = mysql.Connection | mysql.Pool;

Expand Down
2 changes: 1 addition & 1 deletion examples/node-pg/src/db/query_sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code generated by sqlc. DO NOT EDIT.

import { QueryArrayConfig, QueryArrayResult } from "pg";
import type { QueryArrayConfig, QueryArrayResult } from "pg";

interface Client {
query: (config: QueryArrayConfig) => Promise<QueryArrayResult>;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "experiment",
"version": "1.0.0",
"version": "0.0.7",
"description": "",
"main": "app.js",
"scripts": {
Expand Down
8 changes: 4 additions & 4 deletions src/drivers/mysql2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { SyntaxKind, NodeFlags, TypeNode, factory } from "typescript";
import { NodeFlags, SyntaxKind, TypeNode, factory } from "typescript";

// import { writeFileSync, STDIO } from "javy/fs";

import { Parameter, Column, Query } from "../gen/plugin/codegen_pb";
import { Column, Parameter, Query } from "../gen/plugin/codegen_pb";
import { argName, colName } from "./utlis";

export interface Mysql2Options {
Expand Down Expand Up @@ -235,14 +235,14 @@ export class Driver {
factory.createIdentifier("mysql"),
factory.createNamedImports([
factory.createImportSpecifier(
false,
true,
undefined,
factory.createIdentifier("RowDataPacket")
),
...(hasExecLastIdCmd
? [
factory.createImportSpecifier(
false,
true,
undefined,
factory.createIdentifier("ResultSetHeader")
),
Expand Down
4 changes: 2 additions & 2 deletions src/drivers/pg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
FunctionDeclaration,
} from "typescript";

import { Parameter, Column, Query } from "../gen/plugin/codegen_pb";
import { Column, Parameter, Query } from "../gen/plugin/codegen_pb";
import { argName, colName } from "./utlis";

function funcParamsDecl(iface: string | undefined, params: Parameter[]) {
Expand Down Expand Up @@ -340,7 +340,7 @@ export class Driver {
factory.createImportDeclaration(
undefined,
factory.createImportClause(
false,
true,
undefined,
factory.createNamedImports([
factory.createImportSpecifier(
Expand Down