Make doesTableExist check for table in current search path
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially for when errors happen during a connection, or when we have an advisory lock
Poll once per second trying to acquire the lock, rather than waiting in a long-running transaction. CREATE INDEX CONCURRENTLY needs to wait for all running txs to finish before starting, which can lead to deadlocks. Fixes ThomWright#36
With npm update
The `@types/pg` package hasn't published a b8 version yet, so for now I'm relying on the tests passing. Fixes ThomWright#42 Closes ThomWright#43
The 'consecutive IDs' check now runs earlier, after file loading. Fixes ThomWright#51
|
Sorry - created this in error ... wanted to port your fix to our forked repo since it's not merged/released yet. Will just replicate in our fork for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per ThomWright#33 ... get this into our fork so we can merge latest changes and publish until it's available in core lib.