Skip to content

React 19.1 captureOwnerStack #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

React 19.1 captureOwnerStack #146

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db7efa5
react 19.1 captureOwnerStack
Freddy03h Oct 17, 2025
9d612c9
use return decorator for captureOwnerStack
Freddy03h Oct 31, 2025
2766a12
return null_to_opt instead of nullable
Freddy03h Nov 2, 2025
b386ca8
add comment
Freddy03h Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"rescript": "^11.0.0"
},
"peerDependencies": {
"react": ">=19.0.0",
"react-dom": ">=19.0.0"
"react": ">=19.1.0",
"react-dom": ">=19.1.0"
}
}
}
3 changes: 3 additions & 0 deletions src/React.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,3 +451,6 @@ external useOptimistic: (
/** `act` is a test helper to apply pending React updates before making assertions. */
@module("react")
external act: (unit => promise<unit>) => promise<unit> = "act"

@module("react") @return(nullable)
Copy link
Member

@cknitt cknitt Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @return(null_to_opt) would make the intention clearer as the API can only return string or null according to the docs (but not undefined).

external captureOwnerStack: unit => option<string> = "captureOwnerStack"
Copy link
Member

@nojaf nojaf Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: add a doc comment with link to https://react.dev/reference/react/captureOwnerStack

Copy link
Collaborator Author

@Freddy03h Freddy03h Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to format it? I don't see any other comment with link to the react doc.

Copy link
Member

@nojaf nojaf Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't mean you shouldn't add it.
Try something like /** url */