fix: Properly handle annotating leading whitespace #334
+58
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustchas a test for annotating a no-break space near the start of a line with whitespace following it.annotate-snippetscurrently fails this test because it usesstd::char::is_whitespacefor calculatingwhitespace_left, which treats no-break space as whitespace, leadingwhitespace_leftto be larger thanlabel_right, which causes a subtract with overflow panic.rustcgets around this by usingrustc_parse::is_whitespace, which does not treat a no-break space as whitespace. That solution only masks the problem, as it would still panic when annotating whitespace chars with more whitespace following them. Instead, this PR fixes theMargincalculations to allow annotating whitespace before more whitespace.