Fix let_unit_value to lint when explicit unit type annotation is present #15975
+145
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Remove the early return that was skipping let bindings with explicit `()` type annotations. The lint should trigger for redundant unit bindings regardless of whether the type is explicitly annotated or inferred.
matanshavit
force-pushed
the
fix-let-unit-value-explicit-type-15957
branch
from
b2809e4 to
90a46e9
Compare
Member
|
r? clippy |
samueltardieu
requested changes
Oct 29, 2025
Member
There was a problem hiding this comment.
Error markers should be identical to the other one used for testing this lint (let_unit_value, not ERROR). LLM generated probably?
Also please don't use lengthy LLM generated messages for the PR description, this is tedious to read and brings little value.
Author
Fixed, that's for pointing that out.
Understood. Sorry for the excess. I've shortened the description to just the changelog entry, reference to issue number, and short description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
let_unit_value]: Now lints when explicit unit type annotation is presentfixes #15957
This PR fixes the
let_unit_valuelint to trigger even when an explicit()type annotation is present.