fix(while_let_on_iterator): avoid .by_ref() in &mut self trait methods #16029

KDhruv3 · 2025-11-04T16:19:48Z

) changelog: none

…mes (rust-lang#15847) changelog: none

This should address rust-lang#13099 for the let_unit test. changelog: [manual_assert]: Updated manual_assert to use multipart_suggestions where appropriate

Some methods lints were handled in the `methods` module outside the `check_methods()` function.

Some methods lints were handled in the `methods` module outside the `check_methods()` function. changelog: none

it's now just the first arm

changelog: [`unnecessary_option_map_or_else`]: Added lint unnecessary_option_map_or_else. As suggested in the issue description, the implementation takes as reference the issue rust-lang#7328. The tests for lints `option_if_let_else` and `or_fun_call` needed to be adjusted to comply with new lint. fixes rust-lang#14588

I'll still take care of my currently-assigned reviews. Edit: Sorry Philipp, I forgot to r? ghost changelog:none

@blyxyas

…-lang#15849) changelog: [`expl_impl_clone_on_copy`]: honor `allow`/`expect` attributes on both the type declaration and the `impl` Fixes rust-lang#15842 r? @blyxyas

Closes rust-lang#15555 changelog: [`use_self`]: Check structs and enums

…#15859) changelog: none

this destructuring is.. a bit weird

misc stuff I found while working on rust-lang#15343. Not sure about the `P` part, but the rest should be fine changelog: none

changelog: none

For rust-lang#15569 changelog: none

Needed to split the lint crate. Both the method and loop versions of the lint should also behave the same now. changelog: None

…ons (rust-lang#15930) Reduces boilerplate a bit changelog: none

changelog: none

Closes rust-lang#15968 changelog: [`replace_box`] fix FP when the box is moved r? samueltardieu As you wish   ### Summary Notes - [Beta-nomination](rust-lang#15984 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details*

…-lang#16006) Fixes rust-lang#15987 changelog: [`let_and_return`]: disallow _any_ text between let and return

@Centri3

The "bad" example in the `missing_transmute_annotations` example didn't actually trigger the lint and so wasn't a "bad" example. This PR replaces it with an actual "bad" example. It was discussed on zulip [here](https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/missing_transmute_annotations/near/547657390). changelog: Fix `missing_transmute_annotations` example r? @Centri3

rustbot · 2025-11-04T16:19:53Z

Some changes occurred in clippy_lints/src/doc

cc @notriddle

rustbot · 2025-11-04T16:19:55Z

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-11-04T16:19:59Z

⚠️ Warning ⚠️

There are username mentions (such as @user) in the commit messages of the following commits.
Please remove the mentions to avoid spamming these users.
- 57913b4
- 7c7bd6e
- ec8e8fd
- ab9eb10
- d9fb15c
- 2bb3d0c
- 0c592df
- b69d2ff
- c936595
- ad7fc4f
There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 7b0c3d0
- c5a96d4
- e70b206
- 99b8106
- e6febbd
- 77ce8b8
- 57913b4
- 844fadb
- 70d5c8c
- 42f2ba1
- ebbbbeb
- 7c7bd6e
- d66e5db
- 1f0b8b8
- 35f8bff
- a8d1258
- c6f2557
- eee8ef8
- b26a1aa
- d230acd
- ec8e8fd
- 8116b23
- ab9eb10
- 8697533
- 00e5e1b
- d9fb15c
- 1ecb18a
- 1ac3cc1
- 95dd88d
- 973e596
- 039b40f
- fb82de5
- c6c71af
- fd20839
- 2bb3d0c
- 0c592df
- 00f68d5
- 82d729c
- 09c3237
- c238924
- 8ff0cf8
- f975caa
- 3dcf399
- d1b51ea
- 25cbcb4
- da89652
- c5714b0
- a0a347e
- b0d93f1
- 0029a91
- ca168c0
- 0226fa9
- f144c6c
- d74200a
- 7012a5d
- 35e55a6
- 7c86faa
- 5a90737
- d05f74e
- 5e7ce90
- b69d2ff
- bcc40ce
- e415911
- 0b784f8
- c936595
- c23eed6
- e629869
- f51c555
- a2c13c1
- 7562179
- 31d8210
- 8e8fe61
- 6729799
- e121ab8
- a456519
- ad7fc4f
The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- 0029a91
- 00e5e1b
- 00f68d5
- 0226fa9
- 039b40f
- 05aaed9
- 09c3237
- 0b784f8
- 0c592df
- 14b446c
- 1ac3cc1
- 1ecb18a
- 1f0b8b8
- 25cbcb4
- 2bb3d0c
- 2c1ceea
- 2c8a9e2
- 31d8210
- 35e55a6
- 35f8bff
- 3dcf399
- 42f2ba1
- 52fa003
- 57913b4
- 5a90737
- 5e7ce90
- 6729799
- 7012a5d
- 70d5c8c
- 7562179
- 77ce8b8
- 7b0c3d0
- 7c7bd6e
- 7c86faa
- 8116b23
- 82d729c
- 844fadb
- 8697533
- 8d15b5f
- 8e8fe61
- 8ff0cf8
- 95dd88d
- 973e596
- 99b8106
- a0a347e
- a2c13c1
- a456519
- a8d1258
- ab15129
- ab9eb10
- ad7fc4f
- b0d93f1
- b26a1aa
- b69d2ff
- bcc40ce
- c23eed6
- c5714b0
- c5a96d4
- c6c71af
- c6f2557
- c936595
- ca168c0
- cd5b0b6
- cf7aaa5
- d05f74e
- d1b51ea
- d230acd
- d66e5db
- d74200a
- d9fb15c
- da89652
- e121ab8
- e415911
- e629869
- e6febbd
- e70b206
- ebbbbeb
- ec8e8fd
- eee8ef8
- f144c6c
- f51c555
- f64e401
- f975caa
- fb82de5
- fd20839
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease
```

Alexendoo · 2025-11-04T16:26:09Z

It looks like your branch https://github.com/KDhruv3/rust-clippy/tree/fix/while-let-on-iterator doesn't have any commits past https://github.com/rust-lang/rust-clippy/commits/master/

All the listed commits here are because the PR is opened against the stable branch, I would suggest making sure you've pushed the commits to your fix/while-let-on-iterator branch and then open a PR against master. You might be able to change the target of an existing PR but I'm not sure on that one

github-actions · 2025-11-04T16:29:20Z

Lintcheck changes for ad7fc4f

Lint	Added	Removed	Changed
`clippy::assertions_on_constants`	0	0	1
`clippy::cast_possible_wrap`	0	0	253
`clippy::cast_sign_loss`	0	0	294
`clippy::derivable_impls`	0	0	21
`clippy::expl_impl_clone_on_copy`	0	0	326
`clippy::float_cmp`	0	2	1
`clippy::float_cmp_const`	2	0	0
`clippy::if_then_some_else_none`	0	8	1
`clippy::implicit_return`	21	0	0
`clippy::incompatible_msrv`	6	6	0
`clippy::inefficient_to_string`	0	5	0
`clippy::integer_division_remainder_used`	0	0	1186
`clippy::invalid_upcast_comparisons`	0	1	0
`clippy::let_and_return`	0	2	0
`clippy::let_unit_value`	0	0	4
`clippy::manual_assert`	0	0	70
`clippy::manual_is_infinite`	0	2	0
`clippy::match_same_arms`	0	0	10
`clippy::missing_const_for_fn`	0	4	0
`clippy::missing_trait_methods`	0	0	41210
`clippy::mod_module_files`	0	4	25
`clippy::mut_mut`	0	0	11
`clippy::mutex_atomic`	0	14	0
`clippy::needless_doctest_main`	2	24	11
`clippy::non_ascii_literal`	0	0	15
`clippy::option_option`	0	0	21
`clippy::ptr_offset_with_cast`	0	0	2
`clippy::range_plus_one`	0	0	9
`clippy::rest_pat_in_fully_bound_structs`	0	0	2
`clippy::self_named_module_files`	1	4	6
`clippy::semicolon_if_nothing_returned`	0	0	168
`clippy::test_attr_in_doctest`	2	0	1
`clippy::too_long_first_doc_paragraph`	0	0	21
`clippy::unchecked_duration_subtraction`	0	3	0
`clippy::unchecked_time_subtraction`	7	0	0
`clippy::undocumented_unsafe_blocks`	0	18	1
`clippy::unnecessary_mut_passed`	0	0	1
`clippy::unnecessary_safety_comment`	16	0	269
`clippy::unnecessary_unwrap`	0	0	1
`clippy::use_self`	59	3	4
`clippy::useless_conversion`	0	0	3

This comment will be updated if you push new changes

BoxyUwU and others added 30 commits October 7, 2025 23:02

rename select_where_possible and select_all_or_error

f6336bc

chore: update manual_assert span suggestions

8ef9057

Make obfuscated_if_else a bit more type-safe

d1be6d8

refactor(obfuscated_if_else): make a bit more type-safe (rust-lang#15846

7b0c3d0

) changelog: none

perf(get_unwrap): avoid calling is_type_diagnostic_item multiple times

80b886e

perf(get_unwrap): avoid calling is_type_diagnostic_item multiple ti…

c5a96d4

…mes (rust-lang#15847) changelog: none

Honor allow/expect attributes on ADT and impl Clone nodes

69bd890

chore: multipart_suggestions for manual_assert (rust-lang#13787)

e70b206

This should address rust-lang#13099 for the let_unit test. changelog: [manual_assert]: Updated manual_assert to use multipart_suggestions where appropriate

Cleanup: do not handle methods from several places

c425389

Some methods lints were handled in the `methods` module outside the `check_methods()` function.

Cleanup: do not handle methods from several places (rust-lang#15751)

99b8106

Some methods lints were handled in the `methods` module outside the `check_methods()` function. changelog: none

fix(clone_on_ref_ptr): only name the generic type if possible

6b697db

clean-up

6d0fafd

inline find_matches_sugg into check_if_let

62e1225

inline is_if_let into all callers

27d5f5c

inline arms_without_last into all callers

8519d49

it's now just the first arm

inline arms into all callers

d1d5f0c

inline find_matches_sugg into check_match

83e2b3d

match arm pats aren't Optional anymore

bf5170a

split arms into first, last, and middle pats as slice

0efe3cf

inline {first,last}_{attrs,expr,pat,guard} into all callers

dd7f605

final refactor and docs

0535908

Mark blyxyas on vacation

343e780

Mark blyxyas on vacation (rust-lang#15856)

77ce8b8

I'll still take care of my currently-assigned reviews. Edit: Sorry Philipp, I forgot to r? ghost changelog:none

Honor allow/expect attributes on ADT and impl Clone nodes (rust…

57913b4

…-lang#15849) changelog: [`expl_impl_clone_on_copy`]: honor `allow`/`expect` attributes on both the type declaration and the `impl` Fixes rust-lang#15842 r? @blyxyas

Check structs and enums for use_self

b71fe92

Check structs and enums for use_self (rust-lang#15566)

844fadb

Closes rust-lang#15555 changelog: [`use_self`]: Check structs and enums

Remove StatementKind::Deinit.

1557560

Autolabel PR touching declared_lints.rs with needs-fcp

6a08a85

Autolabel PR touching declared_lints.rs with needs-fcp (rust-lang…

70d5c8c

…#15859) changelog: none

ada4a and others added 20 commits October 31, 2025 21:21

use ExtractIf

34abe4e

match on kind directly

adf38c0

this destructuring is.. a bit weird

use if let

31b7ddc

rm some Boxes

44e3b16

clean-up

e7b4ae8

move ptr.rs to ptr/mod.rs

54a84c1

extract each lint into its own module

ccd5130

clean-up unnested_or_patterns (rust-lang#15344)

f51c555

misc stuff I found while working on rust-lang#15343. Not sure about the `P` part, but the rest should be fine changelog: none

refactor(ptr): split each lint into a separate module (rust-lang#16001)

a2c13c1

changelog: none

Overhaul and document clippy_utils::attrs (rust-lang#15763)

7562179

For rust-lang#15569 changelog: none

fix(let_and_return): disallow _any_ text between let and return

6bc8d21

unused_enumerate_index: move to loops lint pass (rust-lang#15279)

31d8210

Needed to split the lint crate. Both the method and loop versions of the lint should also behave the same now. changelog: None

Introduce helper functions for Some(x)/None patterns and expressi…

8e8fe61

…ons (rust-lang#15930) Reduces boilerplate a bit changelog: none

Fix spacing typo in new inefficient_to_string info (rust-lang#15888)

6729799

changelog: none

fix: replace_box FP when the box is moved

098ded3

fix(let_and_return): disallow _any_ text between let and return (rust…

a456519

…-lang#16006) Fixes rust-lang#15987 changelog: [`let_and_return`]: disallow _any_ text between let and return

Fix missing_transmute_annotations example

8f9ef1c

Remove no_run tags on missing_transmute_annotations code examples

0afbb65

rustbot added needs-fcp S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 4, 2025

rustbot assigned Alexendoo Nov 4, 2025

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(while_let_on_iterator): avoid .by_ref() in &mut self trait methods #16029

fix(while_let_on_iterator): avoid .by_ref() in &mut self trait methods #16029

KDhruv3 commented Nov 4, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

Alexendoo commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

38 participants

fix(while_let_on_iterator): avoid .by_ref() in &mut self trait methods #16029

Are you sure you want to change the base?

fix(while_let_on_iterator): avoid .by_ref() in &mut self trait methods #16029

Conversation

KDhruv3 commented Nov 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

rustbot commented Nov 4, 2025

Uh oh!

Alexendoo commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

38 participants

KDhruv3 commented Nov 4, 2025 •

edited by rustbot

Loading