double_comparisons: check for expressions such as x != y && x >= y
#16033
+69
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands the
double_comparisonslint to check for expressions of the formx != y && x >= yandx != y && x <= y. Since the lint already checks for their dual (x == y || x < yandx == y || x > y, respectively) while also checking forx <= y && x >= yand its dualx > y || x < y, it seemed like these two new cases were, in some sense, missing.Issues #685 and #753 appear pertinent here.
changelog: [
double_comparisons] check and offer suggestions for expressions such asx != y && x >= y