Start using pattern types in libcore #136006

oli-obk · 2025-01-24T16:24:51Z

cc #135996

compiler-errors

Well r=me when/if it does get unblocked.

library/core/src/num/niche_types.rs

rustbot · 2025-01-27T09:38:22Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Veykril · 2025-01-27T09:54:06Z

Re rust-analyzer blocker, as it turns out to implement pattern types (to a degree that would unblock this) it comes down to the same architecture changes required as for rust-lang/rust-analyzer#7434 (which I am currently looking into), so that will take a bit.

rustbot · 2025-01-27T15:53:28Z

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

compiler/rustc_const_eval/src/interpret/validity.rs

compiler/rustc_mir_transform/src/validate.rs

oli-obk · 2025-10-31T11:27:52Z

...ir-opt/pre-codegen/drop_boxed_slice.generic_in_place.PreCodegen.after.32bit.panic-unwind.mir

+        _10 = copy _9 as (*const u8) is !null (Transmute);
+        StorageDead(_9);
+        StorageLive(_11);
+        _11 = copy _10 as *mut u8 (Transmute);


we lose some GVN for now, could try to first fix this without changing libstd

oli-obk · 2025-10-31T11:28:36Z

tests/codegen-llvm/loads.rs

 #[no_mangle]
 pub fn load_box<'a>(x: Box<Box<i32>>) -> Box<i32> {
-    // CHECK: load ptr, ptr %{{.*}}, align [[PTR_ALIGNMENT]], !nonnull !{{[0-9]+}}, !align ![[ALIGN_4_META]], !noundef !{{[0-9]+}}
+    // CHECK: load ptr, ptr %{{.*}}, align [[PTR_ALIGNMENT]], !nonnull !{{[0-9]+}}, !noundef !{{[0-9]+}}


need to investigate what made us lose this

Add NonNull pattern types These are the final piece missing for * rust-lang/rust#136006 We cannot use the previous scheme of using an integer range for raw pointers, as we're not just changing the layout of raw pointers anymore, but also the type representation. And we can't represent "any provenance or NonZero<usize>" natively as patterns. So I created a new `!null` pattern. Since this is all unstable representation stuff for replacing rustc_layout_scalar_range_start with pattern types, the divergence from normal patterns is fine, especially since T-lang seems interested in exploring general negation patterns r? `@BoxyUwU`

rustbot · 2025-11-04T10:05:15Z

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

bors · 2025-11-05T10:49:19Z

☔ The latest upstream changes (presumably #148507) made this pull request unmergeable. Please resolve the merge conflicts.

Use `!null` pattern type in libcore

rustbot · 2025-11-05T12:17:37Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk · 2025-11-05T12:18:27Z

@bors try @rust-timer queue

Start using pattern types in libcore

rust-bors · 2025-11-05T14:36:11Z

☀️ Try build successful (CI)
Build commit: e177b34 (e177b3401e07dfa6c1b49cab6144bfd78d8ee7e1, parent: 8e0b68e63cd2b7b6d18474fe6f49df6fb1570c25)

rust-timer · 2025-11-05T17:15:08Z

Finished benchmarking commit (e177b34): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.2%, 3.4%]	17
Regressions ❌ (secondary)	0.9%	[0.1%, 3.4%]	12
Improvements ✅ (primary)	-0.6%	[-2.8%, -0.2%]	11
Improvements ✅ (secondary)	-0.7%	[-1.2%, -0.3%]	2
All ❌✅ (primary)	0.7%	[-2.8%, 3.4%]	28

Max RSS (memory usage)

Results (primary -0.0%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.5%, 5.0%]	3
Regressions ❌ (secondary)	2.2%	[1.2%, 3.0%]	3
Improvements ✅ (primary)	-4.7%	[-4.7%, -4.7%]	2
Improvements ✅ (secondary)	-3.7%	[-4.9%, -1.4%]	10
All ❌✅ (primary)	-0.0%	[-4.7%, 5.0%]	5

Cycles

Results (primary -1.3%, secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	5.0%	[2.6%, 8.8%]	5
Improvements ✅ (primary)	-2.9%	[-3.4%, -2.5%]	2
Improvements ✅ (secondary)	-5.4%	[-8.9%, -1.7%]	8
All ❌✅ (primary)	-1.3%	[-3.4%, 2.1%]	3

Binary size

Results (primary 1.0%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.0%, 7.6%]	48
Regressions ❌ (secondary)	1.1%	[0.0%, 7.6%]	15
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	5
Improvements ✅ (secondary)	-1.1%	[-2.1%, -0.0%]	2
All ❌✅ (primary)	1.0%	[-0.1%, 7.6%]	53

Bootstrap: 475.57s -> 475.799s (0.05%)
Artifact size: 390.76 MiB -> 391.12 MiB (0.09%)

rustbot assigned ibraheemdev Jan 24, 2025

This comment was marked as outdated.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025

oli-obk added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025

oli-obk unassigned ibraheemdev Jan 24, 2025

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from e3e2cbd to ff4d569 Compare January 24, 2025 16:36

compiler-errors approved these changes Jan 24, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

scottmcm reviewed Jan 25, 2025

View reviewed changes

library/core/src/num/niche_types.rs Outdated Show resolved Hide resolved

oli-obk force-pushed the push-tzonluoyuwkq branch from ff4d569 to 0409353 Compare January 27, 2025 09:05

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from 0409353 to 4db40b9 Compare January 27, 2025 09:38

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from 4db40b9 to 0afd16b Compare January 27, 2025 11:12

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from 0afd16b to ed90eb8 Compare January 27, 2025 11:41

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from ed90eb8 to 9514a86 Compare January 27, 2025 12:10

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from 9514a86 to 9774687 Compare January 27, 2025 15:15

This comment has been minimized.

Sign in to view

RalfJung reviewed Jan 27, 2025

View reviewed changes

compiler/rustc_const_eval/src/interpret/validity.rs Outdated Show resolved Hide resolved

oli-obk mentioned this pull request Jan 27, 2025

Test validity of pattern types #136145

Merged

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch 2 times, most recently from 1d9d61a to 3b571c7 Compare October 31, 2025 10:19

This comment has been minimized.

Sign in to view

oli-obk commented Oct 31, 2025

View reviewed changes

oli-obk force-pushed the push-tzonluoyuwkq branch from 3b571c7 to 6594ab7 Compare November 4, 2025 08:09

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-tzonluoyuwkq branch from 6594ab7 to 18c0c6a Compare November 4, 2025 10:05

rustbot added the A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` label Nov 4, 2025

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 5, 2025

oli-obk force-pushed the push-tzonluoyuwkq branch from 18c0c6a to 154a8aa Compare November 5, 2025 11:40

oli-obk added 2 commits November 5, 2025 12:17

Start using pattern types in libcore

0db8653

Use !null pattern type in libcore

3727ca4

Use `!null` pattern type in libcore

oli-obk force-pushed the push-tzonluoyuwkq branch from 154a8aa to 3727ca4 Compare November 5, 2025 12:17

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Nov 5, 2025

Auto merge of #136006 - oli-obk:push-tzonluoyuwkq, r=<try>

e177b34

Start using pattern types in libcore

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 5, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 5, 2025

oli-obk mentioned this pull request Nov 5, 2025

[perf] Start using pattern types in libcore #148537

Open

Start using pattern types in libcore #136006

Are you sure you want to change the base?

Start using pattern types in libcore #136006

Conversation

oli-obk commented Jan 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

rustbot commented Jan 27, 2025

Uh oh!

Veykril commented Jan 27, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jan 27, 2025

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

oli-obk Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

oli-obk Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Nov 4, 2025

Uh oh!

This comment has been minimized.

bors commented Nov 5, 2025

Uh oh!

rustbot commented Nov 5, 2025

Uh oh!

oli-obk commented Nov 5, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Nov 5, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Nov 5, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

oli-obk commented Jan 24, 2025 •

edited by rustbot

Loading