Port cfg!() macro to the new attribute parsing system
#147945
Merged
+187
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
JonathanBrouwer
commented
Oct 21, 2025
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
cfg_macro
branch
from
e4bea66 to
58efee4
Compare
JonathanBrouwer
added
the
S-blocked
jdonszelmann
requested changes
Oct 21, 2025
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 25, 2025
…lmann Improvements to attribute suggestions Changes in commit 1: - Add `AcceptContext::suggestions`, which retrieves the suggestions for the currently parsing attribute - This happens to fix a bug in the way `#[macro_export`]. Closes rust-lang#147987 Changes in commit 2: - Add a check to the suggestions function so the suggestions for attributes in cfg_attr are nicer. Fixes rust-lang#147693 This is also part (but not all) of the changes needed to unblock rust-lang#147945 r? `@jdonszelmann`
rust-timer
added a commit
that referenced
this pull request
Oct 25, 2025
Rollup merge of #148000 - JonathanBrouwer:wipnew2, r=jdonszelmann Improvements to attribute suggestions Changes in commit 1: - Add `AcceptContext::suggestions`, which retrieves the suggestions for the currently parsing attribute - This happens to fix a bug in the way `#[macro_export`]. Closes #147987 Changes in commit 2: - Add a check to the suggestions function so the suggestions for attributes in cfg_attr are nicer. Fixes #147693 This is also part (but not all) of the changes needed to unblock #147945 r? `@jdonszelmann`
JonathanBrouwer
force-pushed
the
cfg_macro
branch
2 times, most recently
from
c4a74e6 to
c8d68a9
Compare
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
JonathanBrouwer
removed
the
S-blocked
jdonszelmann
approved these changes
Nov 3, 2025
| #[derive(Copy, Clone)] | ||
| pub enum ParsedDescription { | ||
| Attribute, | ||
| Macro, |
There was a problem hiding this comment.
could you comment on the reason why this is needed? It's not obvious that we're using an attribute parser for non-attributes. r=me after that
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
JonathanBrouwer
force-pushed
the
cfg_macro
branch
from
c8d68a9 to
a628e71
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=jdonszelmann rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 3, 2025
…zelmann Port `cfg!()` macro to the new attribute parsing system r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Nov 3, 2025
Rollup of 7 pull requests Successful merges: - #147141 (Suggest making binding `mut` on `&mut` reborrow) - #147945 (Port `cfg!()` macro to the new attribute parsing system ) - #147951 (Add check for `+=` typo in let chains) - #148004 (fix: Only special case single line item attribute suggestions) - #148264 (reflect that type and const parameter can be intermixed) - #148363 (Fix `wasm_import_module` attribute cross-crate) - #148447 (Tweak E0401) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 4, 2025
Rollup merge of #147945 - JonathanBrouwer:cfg_macro, r=jdonszelmann Port `cfg!()` macro to the new attribute parsing system r? ``@jdonszelmann``
mu001999
reviewed
Nov 4, 2025
| | ^^^^^^^^--^ | ||
| | | | | ||
| | | expected a single argument here | ||
| | help: must be of the form: `cfg(predicate)` |
There was a problem hiding this comment.
this should be cfg!(predicate), right?
There was a problem hiding this comment.
True! Good spot, I'll make sure to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann