Skip to content

Conversation

@frank-king
Copy link
Contributor

@frank-king frank-king commented Nov 2, 2025

Implement &pin patterns and ref pin binding modes, part of pin ergonomics.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 2, 2025
@rust-log-analyzer

This comment has been minimized.

@frank-king frank-king changed the title [WIP] implement pin patterns Implement &pin patterns and ref pin binding modes Nov 5, 2025
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] askama test:false 0.172
error[E0023]: this pattern has 2 fields, but the corresponding tuple variant has 3 fields
    --> src/librustdoc/clean/utils.rs:306:40
     |
 306 |         PatKind::Box(p) | PatKind::Ref(p, _) | PatKind::Guard(p, _) => return name_from_pat(p),
     |                                        ^  ^ expected 3 fields, found 2
     |
    ::: /checkout/compiler/rustc_hir/src/hir.rs:1918:9
     |
1918 |     Ref(&'hir Pat<'hir>, Pinnedness, Mutability),
     |         ---------------  ----------  ---------- tuple variant has 3 fields
     |
help: use `_` to explicitly ignore each field
     |
 306 |         PatKind::Box(p) | PatKind::Ref(p, _, _) | PatKind::Guard(p, _) => return name_from_pat(p),
     |                                            +++

For more information about this error, try `rustc --explain E0023`.
[RUSTC-TIMING] rustdoc test:false 3.616
error: could not compile `rustdoc` (lib) due to 1 previous error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants