Skip to content

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Nov 4, 2025

Take the configuration used by other teams to create Zulip topics for T-libs backports.

r? @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
@rustbot

This comment has been minimized.

@tgross35
Copy link
Contributor Author

tgross35 commented Nov 4, 2025

^ That's preexisting but also seems correct?

@Urgau
Copy link
Member

Urgau commented Nov 4, 2025

The span of the error is misleading/wrong. It's the zulip_stream = "" parts that are the issue, zulip_stream only accepts a number not a string.

@tgross35 tgross35 force-pushed the triagebot-libs-backports branch from 9179b18 to e1eba5f Compare November 4, 2025 21:35
Take the configuration used by other teams to create Zulip topics for
T-libs backports.
@tgross35 tgross35 force-pushed the triagebot-libs-backports branch from e1eba5f to f7f0ca4 Compare November 4, 2025 21:41
@Amanieu
Copy link
Member

Amanieu commented Nov 5, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2025

📌 Commit f7f0ca4 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2025
bors added a commit that referenced this pull request Nov 5, 2025
Rollup of 8 pull requests

Successful merges:

 - #147994 (Deduplicate deprecation warning when using unit or tuple structs)
 - #148440 ([rustdoc search] Simplify itemTypes and filter "dependencies")
 - #148501 (triagebot: Create Zulip topics for libs backports)
 - #148517 (Remove no longer necessary lint allow)
 - #148518 (Unify the configuration of the compiler docs)
 - #148523 (miri subtree update)
 - #148525 (Fix ICE from lit_to_mir_constant caused by type error)
 - #148534 (Merge `Vec::push{,_mut}_within_capacity`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f3b186 into rust-lang:master Nov 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 6, 2025
rust-timer added a commit that referenced this pull request Nov 6, 2025
Rollup merge of #148501 - tgross35:triagebot-libs-backports, r=Amanieu

triagebot: Create Zulip topics for libs backports

Take the configuration used by other teams to create Zulip topics for T-libs backports.
@tgross35 tgross35 deleted the triagebot-libs-backports branch November 6, 2025 00:21
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 6, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs)
 - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies")
 - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports)
 - rust-lang/rust#148517 (Remove no longer necessary lint allow)
 - rust-lang/rust#148518 (Unify the configuration of the compiler docs)
 - rust-lang/rust#148523 (miri subtree update)
 - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error)
 - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 7, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs)
 - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies")
 - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports)
 - rust-lang/rust#148517 (Remove no longer necessary lint allow)
 - rust-lang/rust#148518 (Unify the configuration of the compiler docs)
 - rust-lang/rust#148523 (miri subtree update)
 - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error)
 - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants