Move warning reporting from flag_to_backend_features to cfg_target_feature #148516
+448
−417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in compiler/rustc_codegen_ssa |
rustbot
added
A-LLVM
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
…ature This way warnings are emitted even in a check build.
bjorn3
force-pushed
the
target_feature_parsing_improvements
branch
from
b7ed069 to
1d34478
Compare
WaffleLapkin
approved these changes
Nov 5, 2025
|
r? WaffleLapkin |
rustbot
removed
the
S-waiting-on-review
|
Error: Assignment is not allowed on a closed PR. Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
rustbot
added
the
S-waiting-on-review
|
Ugh, why did pressing ctrl+enter close the PR 😭 r? WaffleLapkin |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 5, 2025
…=WaffleLapkin Move warning reporting from flag_to_backend_features to cfg_target_feature This way warnings are emitted even in a check build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way warnings are emitted even in a check build.