Unify the configuration of the compiler docs #148518
Conversation
|
cc @davidtwco, @compiler-errors, @TaKO8Ki Some changes occurred in diagnostic error codes Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_gcc This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a Some changes occurred to the CTFE machinery |
rustbot
added
A-attributes
rustbot
added
S-waiting-on-review
| cmd.arg("--cfg=bootstrap"); | ||
| } | ||
|
|
||
| if let Some(crate_name) = parse_value_from_args(&args, "--crate-name") { |
There was a problem hiding this comment.
I don't think this is the right way to do it: would be better to do that in bootstrap instead.
There was a problem hiding this comment.
We can't do it from bootstrap without also marking all non-rustc crates in the compiler docs with the rust logo.
There was a problem hiding this comment.
Is it such an issue for our internal docs? Because with this change, any crate starting with rustc_ will have the logo, which sounds way worse.
There was a problem hiding this comment.
Another issue is that the rustc_proc_macro crate must not get the -Zcrate-attr=feature(rustdoc_internals)] as it already specifies this due to being identical to library/proc_macro. And duplicate feature enabling is a hard error.
There was a problem hiding this comment.
We can special-case rustc_proc_macro and proc_macro to not add this option.
There was a problem hiding this comment.
I just realized: this is in bootstrap. Sorry for completely missing that...
Looks good to me like that. 👍
There was a problem hiding this comment.
How can it be special cased without logic in bootstrap/src/bin/rustdoc.rs?
Edit: Github didn't show your last comment.
There was a problem hiding this comment.
Yeah I was completely wrong. Thought the change was is in librustdoc. No clue how I messed something so badly. ^^'
This comment has been minimized.
This comment has been minimized.
Previously it was rather inconsistent which crates got the rust logo and which didn't and setting html_root_url was forgotten in many cases.
Rustdoc forwards -Zcrate-attr=feature(rustdoc_internals) to doc tests, but deny(warnings) overrides the -Ainternal_features.
bjorn3
force-pushed
the
unify_compiler_doc_config
branch
from
53ca226 to
222480d
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
…r=GuillaumeGomez Unify the configuration of the compiler docs Previously it was rather inconsistent which crates got the rust logo and which didn't and setting html_root_url was forgotten in many cases.
6 participants
Previously it was rather inconsistent which crates got the rust logo and which didn't and setting html_root_url was forgotten in many cases.