Skip to content

Expand pow docs with special-case tests #148526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expand pow docs with special-case tests #148526

wants to merge 1 commit into from

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Nov 5, 2025 •
edited by rustbot
Loading

resolve: #148316

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 5, 2025
reddevilmidzy
reddevilmidzy commented Nov 5, 2025
View reviewed changes
library/core/src/num/f128.rs
Comment on lines +1772 to +1780
/// // Special cases:
/// // pow(x, +-0) = 1 for any x
/// assert_eq!(f128::powi(3.0, 0), 1.0);
///
/// // pow(1, y) = 1 for any y
/// assert_eq!(f128::powi(1.0, 2), 1.0);
///
/// // pow(x, 1) = x for any x
/// assert_eq!(f128::powi(3.0, 1), 3.0);
Copy link
Contributor Author

@reddevilmidzy reddevilmidzy Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you'd prefer these doc tests without the blank lines — I added them for readability, but I can remove them if that fits the style better.

@reddevilmidzy reddevilmidzy marked this pull request as ready for review November 5, 2025 22:57
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify the return value ​​of the exponentiation methods in special cases

3 participants

@reddevilmidzy @rustbot @Mark-Simulacrum