uefi: Implement PciRootBridgeIo bus device enumeration logic #1819
+438
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijikun
changed the title
seijikun
force-pushed
the
mr-pci-enumerate
branch
from
41a55f3 to
6347d3c
Compare
This sorting now actually makes sense from a logical point of view. This is now also the ordering you get by using typical tools like lspci.
seijikun
force-pushed
the
mr-pci-enumerate
branch
4 times, most recently
from
8a96ebf to
c801389
Compare
seijikun
force-pushed
the
mr-pci-enumerate
branch
3 times, most recently
from
8577e6f to
50999b8
Compare
seijikun
force-pushed
the
mr-pci-enumerate
branch
from
50999b8 to
3920b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally gave up on trying to achieve the PCI bus device enumeration without allocation - that's not gonna happen.
I therefore accepted my fate and transformed my version with allocations into an upstreamable state.
This implementation uses the RootBridge's configuration() method to query ACPI information about the bridge. This contains ranges of valid bus addresses (setup & configured by the UEFI firmware), which are then used as starting points for the recursive bus/device/function scan.
The result of this recursive scan is written into a BTreeSet - which now has the ordering you'd expect and are used to from tools like
lspci.Best consumed commit-by-commit :P
Checklist