Fix absolute path handling in SemanticdbTaskListener.absolutePathFromUri
#827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was off by one:
vf://tmp/foo/bar/baz, it would crash withunsupported URIvf://tmp//foo/bar/baz, it would incorrectly produce a relative pathfoo/bar/bazusing the absolute path's segments, which would typically duplicate the-sourcerootvalue and result in an invalid pathLooking at the code, it seems like it is simply splitting by 1 too many slashes: if we want everything after the
vf://tmp/, we need to.split('/', 4)rather than.split('/', 5). This seems fixes both misbehaviors listed above:vf://tmp/foo/bar/baz, it extracts the relativefoo/bar/baz, which is then appended as a sub-path byoptions.sourceroot.resolvevf://tmp//foo/bar/baz, it extracts the absolute/foo/bar/baz, which then remains unchanged and is returned byoptions.sourceroot.resolveTest plan
Tested manually, a local
sbt publishLocalwith these changes fixes downstream issues in tools that consume the semanticdb e.g. scalameta/metals#7913