feat(zhipuai): Add prompt_tokens_details and update default chat options for tests
#4777
+57
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions for tests - Introduced `prompt_tokens_details` with `cached_tokens` field to `ZhiPuAiApi.Usage` - Updated test cases to replace inline `ChatOptions` with `DEFAULT_CHAT_OPTIONS` - Refactored test models to ensure usage of `glm-4-flash` and `glm-4v-flash` as defaults - Added metadata validations for `promptTokensDetails` in response Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
YunKuiLu
commented
Oct 31, 2025
| void enabledThinkingTest(String modelName) { | ||
| UserMessage userMessage = new UserMessage( | ||
| "Are there an infinite number of prime numbers such that n mod 4 == 3?"); | ||
| UserMessage userMessage = new UserMessage("9.11 and 9.8, which is greater?"); |
There was a problem hiding this comment.
To reduce model output latency, use simpler questions
|
Hi @mxsl-gr , please help with code review. |
|
@mxsl-gr Any chance you can review this before the end of this week? We can target to get this in for 1.1.0 GA. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompt_tokens_detailswithcached_tokensfield toZhiPuAiApi.UsageChatOptionswithDEFAULT_CHAT_OPTIONSglm-4-flashandglm-4v-flashas defaultsThe
usage.prompt_tokens_details.cached_tokensfield is used to display the number of tokens served from cache.Related documentation: https://docs.z.ai/api-reference/llm/chat-completion
All the tests have been passed：