Refactor overridden EmbeddingModel dimensions method #4811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskrier
force-pushed
the
make-known-embedding-dimensions-maps-immutable
branch
from
86eb8ad to
87917c7
Compare
- Provide a way to override known embedding dimensions - Make known embedding dimensions maps immutable Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
nicolaskrier
force-pushed
the
make-known-embedding-dimensions-maps-immutable
branch
from
87917c7 to
dd34dda
Compare
nicolaskrier
changed the title
nicolaskrier
commented
Nov 5, 2025
| * @param modelName Embedding generative name to retrieve the dimensions for. | ||
| * @return Returns the embedding dimensions for the model name. | ||
| */ | ||
| public static int dimensions(AbstractEmbeddingModel embeddingModel, String modelName) { |
There was a problem hiding this comment.
I am not sure it is the best solution to avoid source code duplication in embedding models overriding dimensions method.
|
Blocked by this PR (#4810). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.