Fix Docker multi-architecture image platform handling in buildpack operations #47292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the builder propagates the requested image platform to DockerApi.exportLayers so Docker 1.41+ saves layers for the pulled architecture rather than the host default. Add platform-aware tests issue: spring-projects#46665 Signed-off-by: hojooo <ghwn5833@gmail.com>
Capture the digest emitted during the pull stream and inspect name@digest so the newly pulled manifest is always used. issue: spring-projects#46674. Signed-off-by: hojooo <ghwn5833@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
mkhaled2
reviewed
Oct 2, 2025
...latform/src/test/java/org/springframework/boot/buildpack/platform/docker/DockerApiTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: hojooo <ghwn5833@gmail.com>
hojooo
force-pushed
the
fix-build-docker-image
branch
from
66ac80d to
174fdb3
Compare
Signed-off-by: hojooo <ghwn5833@gmail.com>
Signed-off-by: hojooo <ghwn5833@gmail.com>
hojooo
force-pushed
the
fix-build-docker-image
branch
3 times, most recently
from
2a15da3 to
8d5a456
Compare
Signed-off-by: hojooo <ghwn5833@gmail.com>
hojooo
force-pushed
the
fix-build-docker-image
branch
from
8d5a456 to
772add5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Docker platform handling issues that occur when building images for a platform different from the host platform. The changes ensure that platform information is properly propagated throughout the buildpack layer export and multi-architecture image inspection processes.
Related Issues
Root Cause
The issues stemmed from incomplete platform information propagation in the Docker API implementation:
Changes Made
1. Respect pulled digest when inspecting multi-arch images
2. Respect image platform when exporting buildpack layers