Fix typo in HTTP Basic Auth Provider documentation #18123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states that setting the header `X-Requested-By` will remove the `WWW-Authenticate` header from the response. However, after testing this and reading the library code it looks like the header to set is `X-Requested-With` (X-Requested-By is mentioned nowhere except in this documentation file), so I propose this simple PR to fix this. Signed-off-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple documentation typo fix
The documentation states that setting the header
X-Requested-Bywill remove theWWW-Authenticateheader from the response.However, after testing this and reading the library code it looks like the header to set should be
X-Requested-With(X-Requested-By is mentioned nowhere except in this documentation file), so I propose this simple PR to fix this.