Skip to content

Make use of C#14 extension members #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Make use of C#14 extension members #1699

wants to merge 16 commits into from

Conversation

@mus65
Copy link
Contributor

@mus65 mus65 commented Sep 11, 2025

This makes use of the C# 14 extension members to get rid of most ThrowHelper methods and some #if.

There may be more places to make use of it (or maybe I already overdid it 😄 ).

Based on .NET 10 branch #1672

mus65 added 16 commits September 11, 2025 18:21
@mus65
Add .NET 10 target
fb96e1d
@mus65
fix IDE0031
1edc4ff 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0031
@mus65
fix ca5399
45be01f 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5399
@mus65
fix ca1515
d0eb812 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1515
@mus65
fix ca2002
c57b923 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2002
@mus65
fix ca1508
7c7eeb9 
new false positives.

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1508
@mus65
fix ca2000
8775b94 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000
@mus65
fix ca2025
0efb9ee 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2025
@mus65
fix ca1849
cce3cc7 
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1849
@mus65
fix Reverse() overloads
90510ea 
because of https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/10.0/csharp-overload-resolution
@mus65
supress CA2002
85c7895
@mus65
Use extension members for ThrowHelpers
e4fb0c9
@mus65
use extension members for CryptoAbstractions
0770be4
@mus65
use extension member for DateTime.UnixEpoch
f85fe5c
@mus65
use extension members for string.Join etc
cda5b8f
@mus65
use extension members for Convert.To/FromHexString
34bbd2f
@mus65 mus65 mentioned this pull request Sep 11, 2025
Draft
@mus65
Copy link
Contributor Author

mus65 commented Sep 11, 2025

Merged with PR #1672

@mus65 mus65 closed this Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drieseng drieseng Awaiting requested review from drieseng drieseng will be requested when the pull request is marked ready for review drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski will be requested when the pull request is marked ready for review WojciechNagorski is a code owner

@Rob-Hague Rob-Hague Awaiting requested review from Rob-Hague Rob-Hague will be requested when the pull request is marked ready for review Rob-Hague is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mus65