Introduce waiters for Intake Runner, Intake and Intake User #3655
Conversation
|
@yago-123 is this ready for review? Is there a reason this PR is still in draft state? |
I'm doing the |
|
|
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
CHANGELOG.md
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
please remove the empty line
services/intake/wait/wait_test.go
Outdated
|
|
||
| var ( | ||
| PROJECT_ID = uuid.NewString() | ||
| REGION = "eu01" |
There was a problem hiding this comment.
| REGION = "eu01" | |
| const region = "eu01" |
| - **Deprecation:** `StorageUpdate`: updating the performance class field is not possible. | ||
| - `intake`: [v0.3.0](services/intake/CHANGELOG.md#v030) | ||
| - **Feature:** Add wait handlers for `Intake`, `IntakeRunner`, and `IntakeUser` resources. | ||
| - **Improvement:** Add usage examples for the `intake` service. |
There was a problem hiding this comment.
In one of your last commits, you removed the examples again. Is there a reason why they are removed?
There was a problem hiding this comment.
Linter failed because the examples referenced the v0.3.0 intake SDK module which isn't available yet ...
There was a problem hiding this comment.
@yago-123 wrote me he will create a follow-up PR with the examples
There was a problem hiding this comment.
Alright. But then the examples won't be part of this release, so the changelogs should be adjusted
There was a problem hiding this comment.
Alright. But then the examples won't be part of this release, so the changelogs should be adjusted
There was a problem hiding this comment.
Its fine by us if its in next release
Co-authored-by: Ruben Hönle <git@hoenle.xyz>
4 participants
Description
Introduce waiters for Intake Runners, Intakes and Intake Users. This PR is required as part of STACKIT Intake addition in the CLI.
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)