interrupts: Disable EXTI when disabling interrupt #1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling interrupt, it should be done at both NVIC and EXTI level. This avoid to have pending interrupt at EXTI level after call to stm32_interrupt_disable(), which could fire the callback as soon as new call to attachInterrupt(), even without new gpio change. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Contributor
Author
|
I made a sketch on my side to check that gpio toggle while interrupt is detached doesn't fire callback when interrupts is re-attached. |
Contributor
|
Hi @ABOSTM , |
fpistm
approved these changes
Dec 20, 2021
Contributor
|
Hi @ABOSTM , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
interrupts: Disable EXTI when disabling interrupt
When disabling interrupt, it should be done at both NVIC and EXTI level.
This avoid to have pending interrupt at EXTI level after call to
stm32_interrupt_disable(), which could fire the callback as soon as
new call to attachInterrupt(), even without new gpio change.
This PR aims to replace/simplify #1258 (which also replace #1168)