Skip to content

Conversation

@MCUdude
Copy link
Contributor

@MCUdude MCUdude commented Feb 3, 2020

This pinout shares the same layout as the Generic F401Cx and F411Cx.

I followed the instructions you gave in the other PR, but the made Github delete the entire PR. Well, here it is again!

 This pinout shares the same layout as the Generic F401Cx and F411Cx
@fpistm fpistm self-requested a review February 4, 2020 06:55
@fpistm fpistm added the new variant Add support of new bard label Feb 4, 2020
@fpistm fpistm added this to the 1.9.0 milestone Feb 4, 2020
@fpistm fpistm merged commit 48ab6f8 into stm32duino:master Feb 4, 2020
@fpistm
Copy link
Member

fpistm commented Feb 4, 2020

Thanks @MCUdude
Some advice for the next PR:

  • Please add a blank line between commit title and commit description. You can refers to the Contributing.md about good practice for commit message.
  • Reference the new board(s) in the README.md as it is done for other new one.
  • You can remove all "ST-link" related comments for the UART definition.

Thanks 😉

@MCUdude
Copy link
Contributor Author

MCUdude commented Feb 4, 2020

Please add a blank line between commit title and commit description. You can refers to the Contributing.md about good practice for commit message.

I've always used just a blank space. I'll use a line instead!

The only low-pin-count STM32F4's that are missing are currently F405/F415, F412 and F413/423.

Is the name Generic_F4x5Rx an OK name for generic F405/F415Rx's?

@fpistm
Copy link
Member

fpistm commented Feb 4, 2020

Is the name Generic_F4x5Rx an OK name for generic F405/F415Rx's?

If F405 and 415 are closed (same Peripherals Pins) well OK

@MCUdude
Copy link
Contributor Author

MCUdude commented Feb 4, 2020

If F405 and 415 are closed (same Peripherals Pins) well OK

Yes, I've compared the source files I've gotten from the Arduino Tools repo. They are identical except that F415 has some crypto hardware as well. Apart from this, they are completely identical. This is also the case for F413/423 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants