feat(prefer-svelte-reactivity): reporting returned variables

[marekdedic]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: f7def4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@f7def4f

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@f7def4f

View Commit

[baseballyama]

Why should we be forced to use SvelteSet or SvelteMap even when the values aren’t changing?

[marekdedic]

Firstly, this PR is part of a wider effort to move the rule to better detect when variables are "encapsulated" inside a function/class and not report them - this PR is an off-shoot of #1287

But this should make sense even on its own anyway - but I think it does. Example

fileA:

function makeSet() {
  const a = new Set();
  // Populate the set etc.
  return a;
}

export makeSet;

fileB:

<script>
  import { makeSet } from "fileA";

  const a = makeSet();
</script>

<!-- Print the set here -->

<button onclick={a.add(42);}>Click me!</button>

In this example, this PR reports the incorrect usage of Set. I hope to pair it with the rest of #1287 to ignore all encapsulated uses by default so that we don't get too many FPs.

[ota-meshi]

Hmm. This is actually fine as is, right? (It shouldn't be reported, right?)
Could you change it to track the value the function returns, check if there's a mutation, and only report that?

[marekdedic]

I've been thinking about this more and you are right. I think this needs a change of approach. I will probably make an alternative PR.