Skip to content

Change how libraries are specified to the linker #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change how libraries are specified to the linker #890

wants to merge 1 commit into from
+65 −156

Conversation

@daveinglis
Copy link
Contributor

@daveinglis daveinglis commented Nov 4, 2025

  • remove the platform specifics (prefix/suffix checks) from computeLibraryArgs, we now just use LIBRARY_PREFIX and remove any suffix for searchPathFlagsForLD, and moved this into the LinkerSpec.LibrarySpecifier extension, this allows for proper searching of libraries, and linking of dynamic libraries on Windows.

@daveinglis
Copy link
Contributor Author

daveinglis commented Nov 4, 2025

@swift-ci test

@daveinglis daveinglis force-pushed the building_tests_fixes_windows branch 4 times, most recently from 1186e23 to e4ae7e3 Compare November 4, 2025 19:54
@daveinglis
Change how libraries are specified to the linker
d5ee5b6 
- remove the platform specifics from computeLibraryArgs, we now just
  use LIBRARY_PREFIX and remove any suffix for searchPathFlagsForLD,
  and moved this into the LinkerSpec.LibrarySpecifier extension, this
  allows for proper searching of libraries, and linking of dynamic
  libraries on Windows.
@daveinglis daveinglis force-pushed the building_tests_fixes_windows branch from e4ae7e3 to d5ee5b6 Compare November 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh will be requested when the pull request is marked ready for review aciidgh is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules will be requested when the pull request is marked ready for review jakepetroules is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon will be requested when the pull request is marked ready for review mhrawdon is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu will be requested when the pull request is marked ready for review neonichu is a code owner

@owenv owenv Awaiting requested review from owenv owenv will be requested when the pull request is marked ready for review owenv is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daveinglis