Force linker to lld on amazon linux 2. #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the gold linker on amazon linux 2 See: https://sourceware.org/bugzilla/show_bug.cgi?id=23016 It is triggered when linking relocatable objects built with LLVM based compilers. * Add gear to detect the os distribution and version * For amazon linux 2 force ALTERNATE_LINKER to lld
kcieplak
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
* Add a series of tests for checking distribution logic.
kcieplak
force-pushed
the
topics/add-os-distribution-version-detection
branch
from
08ff7c4 to
97a028f
Compare
Contributor
Author
|
@swift-ci test |
Previously was getting the computed property multiple times which would reparse files in the filesystem takeing time. Get the propertry once.
owenv
reviewed
Nov 5, 2025
owenv
reviewed
Nov 5, 2025
…ectly. Tests were reimplementing the parsing, which is not of much value. Call the detectHostLinuxDistribution() function directly to exercise the parsing logic. Add a way to pass in a filesystem so we can pass the mocked filesystem.
owenv
approved these changes
Nov 5, 2025
jakepetroules
approved these changes
Nov 5, 2025
Collaborator
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Nice, this looks great! Just some minor formatting feedback.
| let osReleasePath = Path("/etc/os-release") | ||
| if fs.exists(osReleasePath) { | ||
| if let osReleaseData = try? fs.read(osReleasePath), | ||
| let osRelease = String(data: Data(osReleaseData.bytes), encoding: .utf8) { |
Collaborator
There was a problem hiding this comment.
nit: prefer the stdlib constructor instead of the Foundation one:
Suggested change
| let osRelease = String(data: Data(osReleaseData.bytes), encoding: .utf8) { | |
| let osRelease = String(decoding: Data(osReleaseData.bytes), as: UTF8.self) { |
| #expect(distribution == nil) | ||
| } | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
nit: files should end with newlines
Collaborator
There was a problem hiding this comment.
Actually, can you please fix this before merging? #893 adds some validations
Contributor
Author
|
@swift-ci test |
kcieplak
force-pushed
the
topics/add-os-distribution-version-detection
branch
from
d75a53d to
19f6a31
Compare
Mocked filesystem does not work properly with paths like /etc/os-release. No point in running them on Windows
kcieplak
force-pushed
the
topics/add-os-distribution-version-detection
branch
from
19f6a31 to
2da727f
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the gold linker on amazon linux 2
See: https://sourceware.org/bugzilla/show_bug.cgi?id=23016
It is triggered when linking relocatable objects built with LLVM based compilers.