Merge dumped dependency info #897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon and
owenv
as code owners
Sources/SWBTaskExecution/TaskActions/BuildDependencyInfoTaskAction.swift
Outdated
Show resolved
Hide resolved
Sources/SWBTaskExecution/TaskActions/BuildDependencyInfoTaskAction.swift
Outdated
Show resolved
Hide resolved
Since swiftlang#874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now. Additionally, this declares the dependency info file as an output of `ValidateDependencies` which I neglected to do in my earlier PR.
neonichu
force-pushed
the
bbuegling/merge-dependency-info-during-build
branch
from
e097892 to
952eece
Compare
Collaborator
Author
|
@swift-ci please test |
Collaborator
Author
|
Looks like the failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now.
Additionally, this declares the dependency info file as an output of
ValidateDependencieswhich I neglected to do in my earlier PR.