Skip to content

Don't specify explicit linkage for CMake targets #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Don't specify explicit linkage for CMake targets #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/BuildServerProtocol/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
add_library(BuildServerProtocol STATIC
add_library(BuildServerProtocol
Messages.swift

Messages/BuildShutdownRequest.swift
Expand Down
2 changes: 1 addition & 1 deletion Sources/LanguageServerProtocol/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
add_library(LanguageServerProtocol STATIC
add_library(LanguageServerProtocol
Connection.swift
CustomCodable.swift
Error.swift
Expand Down
2 changes: 1 addition & 1 deletion Sources/LanguageServerProtocolTransport/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
add_library(LanguageServerProtocolTransport STATIC
add_library(LanguageServerProtocolTransport
BuildServerMessageDependencyTracker.swift
DisableSigpipe.swift
DocumentURI+CustomLogStringConvertible.swift
Expand Down
4 changes: 2 additions & 2 deletions Sources/SKLogging/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ set(sources
SetGlobalLogFileHandler.swift
SplitLogMessage.swift)

add_library(SKLogging STATIC ${sources})
add_library(SKLogging ${sources})
set_target_properties(SKLogging PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY})
target_link_libraries(SKLogging PRIVATE
$<$<NOT:$<PLATFORM_ID:Darwin>>:Foundation>)
target_link_libraries(SKLogging PUBLIC
ToolsProtocolsSwiftExtensions)

add_library(_SKLoggingForPlugin STATIC ${sources})
add_library(_SKLoggingForPlugin ${sources})
set_target_properties(_SKLoggingForPlugin PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY})
target_compile_options(_SKLoggingForPlugin PRIVATE
Expand Down
4 changes: 2 additions & 2 deletions Sources/ToolsProtocolsSwiftExtensions/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ set(sources
URLExtensions.swift
)

add_library(ToolsProtocolsSwiftExtensions STATIC ${sources})
add_library(ToolsProtocolsSwiftExtensions ${sources})
set_target_properties(ToolsProtocolsSwiftExtensions PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY})
target_link_libraries(ToolsProtocolsSwiftExtensions PUBLIC
ToolsProtocolsCAtomics)
target_link_libraries(ToolsProtocolsSwiftExtensions PRIVATE
$<$<NOT:$<PLATFORM_ID:Darwin>>:Foundation>)

add_library(_ToolsProtocolsSwiftExtensionsForPlugin STATIC ${sources})
add_library(_ToolsProtocolsSwiftExtensionsForPlugin ${sources})
set_target_properties(_ToolsProtocolsSwiftExtensionsForPlugin PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY})
target_link_libraries(_ToolsProtocolsSwiftExtensionsForPlugin PUBLIC
Expand Down