Skip to content

[IRGen] Use 32-bit string hash for type id. #85213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[IRGen] Use 32-bit string hash for type id. #85213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9bcde4
[NFC] IRGen: Lift this function from IGF to IGM.
nate-chandler Oct 29, 2025
83df3f5
[IRGen] TypeID is 0 when typed-malloc is disabled.
nate-chandler Oct 29, 2025
f0f9b56
[IRGen] Use 32-bit string hash for type id.
nate-chandler Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/IRGen/GenPointerAuth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,18 @@ void ConstantAggregateBuilderBase::addSignedPointer(llvm::Constant *pointer,
llvm::ConstantInt::get(IGM().Int64Ty, otherDiscriminator));
}

llvm::ConstantInt *IRGenModule::getMallocTypeId(llvm::Function *fn) {
if (!getOptions().EmitTypeMallocForCoroFrame) {
// Even when typed malloc isn't enabled, a type id may be required for ABI
// reasons (e.g. as an argument to swift_coro_alloc). Use a cheaply
// materialized value.
return llvm::ConstantInt::get(Int64Ty, 0);
}
uint64_t hash = llvm::getStableSipHash(fn->getName());
uint32_t hash32 = (hash % std::numeric_limits<uint32_t>::max()) + 1;
return llvm::ConstantInt::get(Int64Ty, hash32);
}

llvm::ConstantInt* IRGenFunction::getMallocTypeId() {
return getDiscriminatorForString(IGM, CurFn->getName());
return IGM.getMallocTypeId(CurFn);
}
2 changes: 2 additions & 0 deletions lib/IRGen/IRGenModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,6 +1674,8 @@ private: \
llvm::AttributeList constructInitialAttributes();
StackProtectorMode shouldEmitStackProtector(SILFunction *f);

llvm::ConstantInt *getMallocTypeId(llvm::Function *fn);

void emitProtocolDecl(ProtocolDecl *D);
void emitEnumDecl(EnumDecl *D);
void emitStructDecl(StructDecl *D);
Expand Down
4 changes: 2 additions & 2 deletions test/IRGen/yield_once_enable_emit_type_malloc_coro_frame.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ sil @marker : $(Builtin.Int32) -> ()
// CHECK-SAME: [[CORO_ATTRIBUTES:#[0-9]+]]
sil @test_simple : $@yield_once () -> () {
entry:
// CHECK-32: [[ID:%.*]] = call token (i32, i32, ptr, ptr, ptr, ptr, ...) @llvm.coro.id.retcon.once(i32 [[BUFFER_SIZE]], i32 [[BUFFER_ALIGN:4]], ptr %0, ptr @"$sIetA_TC", ptr @__swift_coroFrameAllocStub, ptr @free, i64 38223)
// CHECK-64: [[ID:%.*]] = call token (i32, i32, ptr, ptr, ptr, ptr, ...) @llvm.coro.id.retcon.once(i32 [[BUFFER_SIZE]], i32 [[BUFFER_ALIGN:8]], ptr %0, ptr @"$sIetA_TC", ptr @__swift_coroFrameAllocStub, ptr @free, i64 38223)
// CHECK-32: [[ID:%.*]] = call token (i32, i32, ptr, ptr, ptr, ptr, ...) @llvm.coro.id.retcon.once(i32 [[BUFFER_SIZE]], i32 [[BUFFER_ALIGN:4]], ptr %0, ptr @"$sIetA_TC", ptr @__swift_coroFrameAllocStub, ptr @free, i64 121146903)
// CHECK-64: [[ID:%.*]] = call token (i32, i32, ptr, ptr, ptr, ptr, ...) @llvm.coro.id.retcon.once(i32 [[BUFFER_SIZE]], i32 [[BUFFER_ALIGN:8]], ptr %0, ptr @"$sIetA_TC", ptr @__swift_coroFrameAllocStub, ptr @free, i64 121146903)
// CHECK-NEXT: [[BEGIN:%.*]] = call ptr @llvm.coro.begin(token [[ID]], ptr null)

// CHECK-NEXT: call swiftcc void @marker(i32 1000)
Expand Down