Sema: Exportability check enums and classes in non-library-evolution mode #85369
+256
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
xymus
force-pushed
the
exportability-nle-classes-and-structs
branch
from
5edddb2 to
b107169
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that classes and enums don't reference an implementation-only imported dependency unless they are themselves marked as
@_implementationOnly. This is similar to the logic applied to structs in #85179, ensuring their memory layout visible to clients doesn't depend on the hidden dependency. Also extend checking for super types to structs.This remains gated behind the experimental feature flag
CheckImplementationOnly.