Ensure --use will select the toolchain
#456
Open
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a toolchain was already installed when running `swiftly install --use`, said toolchain was not being set to be used as a different code path was followed. Update the code path to set the toolchain when `--use` is selected even if the toolchain is already installed.
bkhouri
requested review from
cmcgee1024,
etcwilde,
justice-adams-apple and
shahmishal
as code owners
bkhouri
commented
Nov 5, 2025
| try await SwiftlyTests.validateInUse(expected: .newStable) | ||
| } | ||
|
|
||
| /// Verify that the pre-installed toolchain will be marked as in-use if the --use flag is specified. |
There was a problem hiding this comment.
question: is there a place to write a test lower in the test pyramid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a toolchain was already installed when running
swiftly install --use, said toolchain was not being set to be used as a different code path was followed.Update the code path to set the toolchain when
--useis selected even if the toolchain is already installed.