-
-
Notifications
You must be signed in to change notification settings - Fork 112
[Platform] Add support for Cartesia #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unpopular opinion to discuss @OskarStark @chr-hertel but IMHO, the CI should not fail if we're using Small example with the Using PS: There's little to no chance that one day, we store informations in the |
918f8e3 to
bf10243
Compare
|
I don't think that this is an unpopular opinion, it's just something that is not easy to have while having to keep up with the BC promise, see symfony/symfony#62168 (comment) for reasoning. |
bf10243 to
e78d27e
Compare
chr-hertel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples are working, some minor comments.
Thanks already!
e78d27e to
2c5c91b
Compare
chr-hertel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works & looks good 🙌
|
Pipeline still open @Guikingone |
|
Fixed @chr-hertel, sorry for the delay, small issue with HttpClient. |
3685d4a to
00d2c8e
Compare
|
Thank you @Guikingone. |
Hi 👋🏻
Here's the PR for the support of
Cartesiaas a TTS / STT platform.