-
-
Notifications
You must be signed in to change notification settings - Fork 112
Qdrant sync #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qdrant sync #834
Conversation
33fa2a6 to
fcc0b5c
Compare
|
But it still makes sense to have that async capabilities as well? sounds like usually one wouldn't want that? |
|
@chr-hertel I took the approach of keeping the existing functionality working as-is. But if you're suggesting to always make the PUT synchronous, I'm happy to update the PR. I do find it slightly odd that Qdrant chose to make operations async by default. Here's a related issue: qdrant/qdrant#2557 which is actually the exact issue I originally ran into when first using Qdrant. But now I'm hitting other issues related to inserts. So now waiting for a response makes way more sense for my situation. |
|
lets use async default |
|
Yes, think so too 👍 |
|
Agree with @OskarStark on this one, let use |
59d8ba3 to
693fc5a
Compare
|
Updated the default behavior to synchronously add documents |
693fc5a to
89ed6b8
Compare
|
Thank you @natewiebe13. |
Currently, Qdrant PUT operations are async. This forces the user to add checking after the request happens to determine if it was successful or not.
This adds an option to make operations sync so you can handle any errors immediately instead of polling after until the operation completes.